SP2: reconcile SyncPlay flat wire frame-shape#339
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| UnusedCode | 2 medium |
| BestPractice | 12 medium |
| Documentation | 27 minor |
| ErrorProne | 2 medium |
| CodeStyle | 54 minor |
🟢 Metrics 24 complexity · 0 duplication
Metric Results Complexity 24 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SP2: SyncPlay frame-shape reconciliation
Problem
MessageHandler::handle()extracts['data']— flat frames have NOdatakey, so all fields are lostConnection::sendMessage()wraps syncplay payloads underdata(deprecated Tizen envelope)sendError()emitscodewhileMessages::error()useserror_codeFix
Inbound: Pass the whole flat message as payload for syncplay types; keep tolerant unwrap for deprecated
{type,data}envelope (dashboard path unchanged)Outbound: Build every syncplay frame with
Messages::*factories and send flat via newConnection::sendFlat()GROUP_STATE: Emit
{group:{...}, your_id}flat at top level (not underdata)Error: Align
sendError()to emiterror_codeFiles changed
src/Server/WebSocket/MessageHandler.php— flat dispatch + protocol_version validationsrc/Server/WebSocket/Connection.php—sendFlat()methodsrc/Server/WebSocket/ConnectionInterface.php—sendFlat()in contractsrc/Session/SyncPlay/SyncPlayManager.php— error_code alignment + flat GROUP_STATEMessageHandlerFrameShapeTest.php,MessagesFrameShapeTest.phpVerification
./vendor/bin/phpunit— 143 tests, 412 assertions ✅./vendor/bin/phpstan analyze --level=9— no errors ✅./vendor/bin/phpcs PSR-12— no errors ✅Dependency
Pairs with @phlix/syncplay Phase 8 (wire-shape checkpoint)