Skip to content

P1: bound unbounded SELECT * on growing tables#336

Merged
detain merged 1 commit into
masterfrom
fix/server-p1-bounded-select
Jun 29, 2026
Merged

P1: bound unbounded SELECT * on growing tables#336
detain merged 1 commit into
masterfrom
fix/server-p1-bounded-select

Conversation

@detain

@detain detain commented Jun 29, 2026

Copy link
Copy Markdown
Owner

P1: Bound unbounded SELECT * on growing tables

Changes

  • HlsRelayManager::getActiveSessions(): add LIMIT ? + active-rows filter (ended_at IS NULL)
  • Recorder::getAllRecordings(): add LIMIT ? OFFSET ? + time-window filter (30 days)
  • CollectionRepository::findAll(): add LIMIT ? OFFSET ?
  • CollectionManager::findAll(): pass through limit/offset

Tests

  • HlsRelayManagerTest::testGetActiveSessionsIncludesLimit()
  • RecorderTest::testGetAllRecordingsIncludesLimitAndTimeWindow()
  • CollectionRepositoryTest::testFindAllIncludesLimitAndOffset()

Verification

  • ./vendor/bin/phpunit — 39 tests, 66 assertions ✅
  • ./vendor/bin/phpstan analyze --level=9 — no errors ✅
  • ./vendor/bin/phpcs PSR-12 — no errors ✅

HlsRelayManager::getActiveSessions(): add LIMIT + active-rows filter
Recorder::getAllRecordings(): add LIMIT/OFFSET + time-window filter
CollectionRepository::findAll(): add LIMIT/OFFSET
CollectionManager: update to pass limit/offset
New tests: HlsRelayManagerTest, RecorderTest, CollectionRepositoryTest
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 32 minor

Alerts:
⚠ 32 issues (≤ 0 issues of at least minor severity)

Results:
32 new issues

Category Results
Documentation 18 minor
CodeStyle 14 minor

View in Codacy

🟢 Metrics 33 complexity · 0 duplication

Metric Results
Complexity 33
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.97%. Comparing base (e5d4bc5) to head (c643537).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #336      +/-   ##
============================================
+ Coverage     59.93%   59.97%   +0.03%     
  Complexity    13007    13007              
============================================
  Files           481      481              
  Lines         42123    42129       +6     
============================================
+ Hits          25247    25267      +20     
+ Misses        16876    16862      -14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@detain detain merged commit f901840 into master Jun 29, 2026
14 of 16 checks passed
@detain detain deleted the fix/server-p1-bounded-select branch June 29, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant