P1: bound unbounded SELECT * on growing tables#336
Merged
Conversation
HlsRelayManager::getActiveSessions(): add LIMIT + active-rows filter Recorder::getAllRecordings(): add LIMIT/OFFSET + time-window filter CollectionRepository::findAll(): add LIMIT/OFFSET CollectionManager: update to pass limit/offset New tests: HlsRelayManagerTest, RecorderTest, CollectionRepositoryTest
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Documentation | 18 minor |
| CodeStyle | 14 minor |
🟢 Metrics 33 complexity · 0 duplication
Metric Results Complexity 33 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #336 +/- ##
============================================
+ Coverage 59.93% 59.97% +0.03%
Complexity 13007 13007
============================================
Files 481 481
Lines 42123 42129 +6
============================================
+ Hits 25247 25267 +20
+ Misses 16876 16862 -14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P1: Bound unbounded SELECT * on growing tables
Changes
LIMIT ?+ active-rows filter (ended_at IS NULL)LIMIT ? OFFSET ?+ time-window filter (30 days)LIMIT ? OFFSET ?Tests
HlsRelayManagerTest::testGetActiveSessionsIncludesLimit()RecorderTest::testGetAllRecordingsIncludesLimitAndTimeWindow()CollectionRepositoryTest::testFindAllIncludesLimitAndOffset()Verification
./vendor/bin/phpunit— 39 tests, 66 assertions ✅./vendor/bin/phpstan analyze --level=9— no errors ✅./vendor/bin/phpcs PSR-12— no errors ✅