P-B2: Per-entry server-compat and deprecation metadata#3
Merged
Conversation
Adds optional compat/deprecation fields to the catalog schema and populates them for all 4 official entries: - minServerVersion: read from each plugin's phlix_min_server_version at its pinned ref. Used by the server UI to show "incompatible" pre-download when the running server is too old. - maxServerVersion: declared for future use (all entries omit it, meaning no upper bound). - verified: true for all official pinned entries (catalog-maintainer reviewed). Used by the server as part of its default-deny gate. - deprecated / yanked: false for all entries. Declared so operators can use them for third-party catalogs and the schema stays consistent. - deprecationMessage: omitted where not applicable. Schema: added 6 new optional properties to the plugin object in plugins.schema.json, all under additionalProperties:false so stray fields still fail CI. README: updated the example JSON, plugin table (adds Min Server column), and the field table to document all new fields.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements P-B2 from the phlix-plugins remediation plan: adds per-entry
server-compatibility and deprecation metadata to the catalog schema and
populates it for all 4 official entries.
Changes
plugins.schema.json— Added 6 new optional properties to the pluginobject (all under the existing
additionalProperties: falseguard):minServerVersion(semver) — minimum Phlix server version requiredmaxServerVersion(semver) — maximum supported (exclusive upper bound)verified(bool) — whether the entry was reviewed by catalog maintainerdeprecated(bool) — whether the plugin is deprecatedyanked(bool) — whether this version has been withdrawndeprecationMessage(string) — human-readable deprecation noticeplugins.json— PopulatedminServerVersion,verified,deprecated,and
yankedfor all 4 entries (values read from each plugin'sphlix_min_server_versionat its pinned ref):README.md— Updated the example JSON, plugin table (adds "Min Server"column), and the field documentation table.
Notes on remaining items
The remediation plan lists 4 PENDING items. Here is the disposition:
schemaVersion: 2is enforced asconstin the schemaCatalogEntry::fromArray())PluginCatalogService::fetchCatalog()callsSsrfGuard::assertPublicUrl()before fetchingSV-S3c and SV-S4 are server-side concerns (SV-* prefix) that belong in
phlix-server, not phlix-plugins. They are tracked separately for the
phlix-server remediation plan.
Verification
Both pass.