ci: add PHPStan L9 + PHPCS PSR12 + coverage (S1/S2)

.github/workflows/test.yml

@@ -10,7 +10,6 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        # phlix-shared requires PHP ^8.3, so the matrix matches.
         php: ['8.3', '8.4']
     steps:
       - uses: actions/checkout@v6
@@ -19,11 +18,17 @@ jobs:
         uses: shivammathur/setup-php@v2
         with:
           php-version: ${{ matrix.php }}
-          coverage: none
+          coverage: pcov
           tools: composer:v2
 
       - name: Install dependencies
         run: composer install --prefer-dist --no-progress --no-interaction
 
       - name: Run PHPUnit
         run: vendor/bin/phpunit --colors=always
+
+      - name: Run PHPStan
+        run: vendor/bin/phpstan analyse src --level=9
+
+      - name: Run PHPCS
+        run: vendor/bin/phpcs src --standard=PSR12

composer.json

@@ -11,7 +11,9 @@
         "detain/phlix-shared": "^0.6"
     },
     "require-dev": {
-        "phpunit/phpunit": "^10.0"
+        "phpstan/phpstan": "^2.2",
+        "phpunit/phpunit": "^10.0",
+        "squizlabs/php_codesniffer": "^4.0"
     },
     "repositories": [
         { "type": "vcs", "url": "https://github.com/detain/phlix-shared.git" }
@@ -29,5 +31,9 @@
     "config": {
         "optimize-autoloader": true,
         "sort-packages": true
+    },
+    "scripts": {
+        "phpstan": "vendor/bin/phpstan analyse src --level=9",
+        "phpcs": "vendor/bin/phpcs src --standard=PSR12"
     }
 }

phpcs.xml

@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<ruleset name="Phlix Plugin Example">
+    <description>PSR-12 coding standard for phlix-plugin-example</description>
+    <file>src</file>
+    <exclude-pattern>vendor/</exclude-pattern>
+    <rule name="PSR12"/>
+</ruleset>

phpstan.neon

@@ -0,0 +1,4 @@
+parameters:
+    level: 9
+    paths:
+        - src

phpunit.xml

@@ -14,4 +14,9 @@
             <directory>src</directory>
         </include>
     </source>
+    <coverage>
+        <report>
+            <cobertura outputFile="coverage.xml"/>
+        </report>
+    </coverage>
 </phpunit>

src/HelloMetadataProvider.php

@@ -22,15 +22,15 @@
  * progressively replace {@see lookup()} with real metadata lookups
  * against TMDB, TVDB, Fanart.tv, or any other source.
  *
- * ## Lifecycle notes
- *
- * - {@see onEnable()} keeps state minimal — it only stashes the host
- *   container so {@see lookup()} can resolve services lazily if a
- *   future implementation needs them.
- * - {@see subscribedEvents()} returns an empty array; this plugin does
- *   not listen for PSR-14 events. A real metadata provider can leave
- *   this empty too — Phase A's `MetadataManager` invokes providers
- *   directly rather than via the dispatcher.
+     * ## Lifecycle notes
+     *
+     * - {@see onEnable()} is a no-op for the reference plugin; it accepts
+     *   the host container to satisfy the contract but does not retain it.
+     *   Real plugins that need a container should store it as a property.
+     * - {@see subscribedEvents()} returns an empty array; this plugin does
+     *   not listen for PSR-14 events. A real metadata provider can leave
+     *   this empty too — Phase A's `MetadataManager` invokes providers
+     *   directly rather than via the dispatcher.
  *
  * ## Provenance
  *
@@ -65,15 +65,6 @@ final class HelloMetadataProvider implements LifecycleInterface
      */
     private string $greeting;
 
-    /**
-     * Host container handle stashed during {@see onEnable()}. Real
-     * provider implementations resolve `LoggerInterface`, HTTP clients,
-     * or cache services through it; the example does not yet need it
-     * but keeping the reference makes the extension point obvious for
-     * authors copying this class as a starter.
-     */
-    private ?ContainerInterface $container = null;
-
     /**
      * @param string $greeting Override for the greeting returned by
      *     {@see lookup()}. Tests pass a custom value; production
@@ -87,10 +78,8 @@ public function __construct(string $greeting = self::DEFAULT_GREETING)
     /**
      * Loader hook called once when the plugin is enabled.
      *
-     * Stashes the host container so later metadata lookups can resolve
-     * services lazily. Real providers might also open an HTTP client or
-     * warm a cache here — keep it cheap; the loader is in the request
-     * path.
+     * No-op for the reference plugin. Real plugins that need the host
+     * container should store it as a property here.
      *
      * @param ContainerInterface $container Host PSR-11 container.
      *
@@ -100,23 +89,21 @@ public function __construct(string $greeting = self::DEFAULT_GREETING)
      */
     public function onEnable(ContainerInterface $container): void
     {
-        $this->container = $container;
     }
 
     /**
      * Loader hook called once when the plugin is disabled.
      *
-     * Releases the stashed container reference. Plugins that opened
-     * clients in {@see onEnable()} should close them here so the
-     * lifecycle is symmetric.
+     * No-op for the reference plugin. Real plugins that opened resources
+     * in {@see onEnable()} should close them here so the lifecycle is
+     * symmetric.
      *
      * @return void
      *
      * @since 0.1.0
      */
     public function onDisable(): void
     {
-        $this->container = null;
     }
 
     /**