fix(player): open the video player in the app's render mode#98
Merged
Conversation
The player always opened with RendererFactory::autoMode() (terminal-best), ignoring the --mode the rest of the app renders with — so a sixel/iterm2/ quarterblock session dropped to a different mode on playback. PosterLoader::protocol() exposes the active render protocol; openPlayer threads it into PlayerScreen::productionFactory(), which maps it to the matching reel Mode (Mode::tryFrom). An unknown protocol (e.g. 'auto'→'chafa') falls back to auto-detect. With sugar-reel's new quarter-block mode, all of half/quarter-block, ascii/ansi256/truecolor and sixel/kitty/iterm2 now carry through to the player. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The player always opened with
RendererFactory::autoMode()(terminal-best), ignoring the--modethe rest of the app renders with — so a sixel/iterm2/quarterblock session switched to a different mode on playback.PosterLoader::protocol()exposes the active render protocol;openPlayerthreads it intoPlayerScreen::productionFactory(), which maps it to the matching reelMode(Mode::tryFrom), falling back to auto-detect for an unknown protocol. Combined with sugar-reel's new quarter-block mode (sugarcraft#1129), all of half/quarter-block, ascii/ansi256/truecolor and sixel/kitty/iterm2 now carry through to the player.Suite green (2220); PHPStan L9 clean.
🤖 Generated with Claude Code