fix(browse): dedupe continue-watching cards by media item#92
Merged
Conversation
A title watched across several sessions/devices can arrive in the continue-watching payload more than once. Duplicate cards share a media-item id, and a rail only updates the FIRST card with a given id when its poster loads (the rest keep the placeholder) — so the home rail showed the same item repeatedly with empty posters on all but the first. Dedupe in onContinueWatching() by item id, keeping the first (most-recent) occurrence the server returned. This is defence in depth alongside the server-side SQL dedup; either alone fixes the visible bug, together they keep the rail correct even if a duplicate ever slips through. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The home Continue Watching rail showed the same title many times, and only the first duplicate displayed a poster — the rest stayed blank.
The continue-watching payload can contain the same media item more than once (a title watched across several sessions/devices). Duplicate cards share a media-item id, and
Rail::withCard()only updates the first card with a given id when its poster loads — so the duplicates never get a poster.Fix
BrowseScreen::onContinueWatching()now dedupes by item id, keeping the first (most-recent) occurrence the server returned, before building cards.This is defence in depth alongside the server-side SQL dedup (phlix-server#315) — either alone fixes the visible bug; together they keep the rail correct even if a duplicate ever slips through.
Tests
testContinueWatchingDeduplicatesByMediaItem: three entries (two sharing an id) collapse to two cards, in order, keeping the higher-progress first occurrence. Full suite green (2203 tests);srcPHPStan L9-clean.🤖 Generated with Claude Code