WIP: major clean ups for the codebase#86
WIP: major clean ups for the codebase#86hozan23 merged 2 commits intodeta:masterfrom hozan23:general-clean-up
Conversation
|
I see the majority of the changes are adding |
I am not sure about the ideal way of using typing hints in Python. I think |
Optional is the way to go. They are virtually equivalent (see https://peps.python.org/pep-0645/), but optional is a more readable way to express the same thing. |
|
It is probably better to fix the failing tests BEFORE merging more pull requests. |
|
Hey @cclauss thanks for your advice. |
No description provided.