Fix rejection attribute for the reason

[jkeuleya]

Problem
The rejection reason received from DB is not forwarded to DC.

Solution
I think that we were not sending the right parameter within this gem.

Ticket:
https://app.asana.com/1/1204263973539417/project/1210927092983272/task/1210902204050095

[coderabbitai]

📝 Walkthrough

Walkthrough

This change renames the reason parameter and attribute to reason_for_rejection across the order item rejection operation, serializer, and resource definition. The type and optionality remain unchanged, and no other logic or structural modifications are introduced.

Changes

Cohort / File(s)	Change Summary
Contract Parameter Renaming lib/desertcart/marketplace/order_item_rejection/operations/create.rb	Renamed contract parameter from reason to reason_for_rejection; type and optionality unchanged.
Serializer Attribute Renaming lib/desertcart/marketplace/order_item_rejection/serializer.rb	Renamed serializer attribute from reason to reason_for_rejection; affects serialized output key.
Resource Attribute Renaming lib/desertcart/resources/marketplace/order_item_rejection.rb	Renamed resource attribute from reason to reason_for_rejection; type remains the same.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between db75b6f and 9cbc071.

📒 Files selected for processing (3)

• lib/desertcart/marketplace/order_item_rejection/operations/create.rb (1 hunks)
• lib/desertcart/marketplace/order_item_rejection/serializer.rb (1 hunks)
• lib/desertcart/resources/marketplace/order_item_rejection.rb (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (2)

lib/desertcart/marketplace/order_item_rejection/serializer.rb (1)

lib/desertcart/resources/marketplace/order_item.rb (1)

• attribute (7-36)

lib/desertcart/resources/marketplace/order_item_rejection.rb (2)

lib/desertcart/marketplace/order_item_rejection/serializer.rb (2)

• attribute (5-13)
• attribute (6-12)

lib/desertcart/resources/marketplace/order_item.rb (1)

• attribute (7-36)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: test (2.7)

🔇 Additional comments (3)

lib/desertcart/resources/marketplace/order_item_rejection.rb (1)

9-9: Support or confirm removal of the legacy :reason key

I didn’t find any references to the old :reason key in the codebase, but absence of matches isn’t proof that no callers still use it. Please verify that upstream callers (web-app, jobs, specs, serializers) have been updated. If any still rely on :reason, add a transitional alias in lib/desertcart/resources/marketplace/order_item_rejection.rb:

# TODO: Remove once all callers use :reason_for_rejection
attribute :reason, type: LedgerSync::Type::String, aliases: [:reason_for_rejection]

—or, if your framework doesn’t support aliases, add an explicit validation to raise a clear error when :reason is passed.

lib/desertcart/marketplace/order_item_rejection/operations/create.rb (1)

13-13: Verify no stale params reach the contract

The contract now validates :reason_for_rejection. Any client still sending reason: will be rejected with a validation error. Please run the repository-wide grep (see previous comment) and update affected callers or provide a coercion layer.

lib/desertcart/marketplace/order_item_rejection/serializer.rb (1)

11-11: LGTM – serializer matches the new contract

The attribute rename is consistent with the resource and contract. No further action required.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch hotfix/fix_rejection_reason_from_db

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.