Adjust Font Size Of Title On Preview Of Layout 6#112
Open
zubairehmad wants to merge 2 commits intomainfrom
Open
Adjust Font Size Of Title On Preview Of Layout 6#112zubairehmad wants to merge 2 commits intomainfrom
zubairehmad wants to merge 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: naveedshahzad/videoapp_issues#68
Problem Root Cause:
LayoutBodycomponent scaled down theVideocomponent and the title div.useResizeFonthook was also scaled down by0.1667making it appear as2.56px(0.1667 × 16) text which is very hard to see.Current Fix:
useResizeFonthook to ensure the text looks big enough when scaled down.Other Possible Fixes (Opinion):
NOTE: The custom breakpoints that I used can be adjusted further based on testing and/or feedback.