chore(deps): drop rustls-pemfile and bump criterion#141
Merged
Conversation
Removes two dev-only advisory hits surfaced by the daily OSV/RustSec scan: - RUSTSEC-2025-0134 (rustls-pemfile 2.x unmaintained). The `examples/tls_server.rs` PEM parsing moves to `rustls_pki_types::pem`, which is already pulled in transitively via `tokio-rustls 0.26` (no new dependency added). - RUSTSEC-2024-0375 / GHSA-g98v-hv3f-hcfr (`atty` unmaintained, pulled in by `criterion 0.4`). Bump `criterion` to 0.5.1, which replaces `atty` with `is-terminal`. Co-Authored-By: Divy Srivastava <me@littledivy.com>
littledivy
approved these changes
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears two dev-only advisory hits flagged by the daily OSV/RustSec scan, without touching library deps or production code.
rustls-pemfile 2.2is unmaintained (RUSTSEC-2025-0134). The only user wasexamples/tls_server.rs. The example now parses PEM viarustls_pki_types::pem::PemObject, which is already pulled in transitively throughtokio-rustls 0.26— no new dependency added, andrustls-pemfileis removed from[dev-dependencies].criterion 0.4pullsatty 0.2(RUSTSEC-2024-0375 / GHSA-g98v-hv3f-hcfr). Bumped tocriterion = "0.5.1", which replacedattywithis-terminal. Theunmaskbench's API surface (Criterion,Throughput,black_box,criterion_group!,criterion_main!) is unchanged across 0.4 → 0.5.attyandrustls-pemfileare gone from bothCargo.lockandfuzz/Cargo.lock.Test plan
cargo build --locked --all-features --all-targetscargo test --locked --all-features(all tests pass; pre-existingmismatched_lifetime_syntaxeswarning unrelated)cargo bench --bench unmask --no-runcargo fmt -- --checkcd fuzz && cargo check --lockedgrep -E 'atty|rustls-pemfile' Cargo.lock fuzz/Cargo.lock→ no matchesCloses denoland/divybot#568