fix: explicitly set the named lifetime to static#895
Merged
marvinhagemeister merged 1 commit intodenoland:mainfrom Sep 6, 2024
Merged
fix: explicitly set the named lifetime to static#895marvinhagemeister merged 1 commit intodenoland:mainfrom
marvinhagemeister merged 1 commit intodenoland:mainfrom
Conversation
Due to a change in Rust nightly, the Rust linter now warns when an elided lifetime ends up being a named lifetime [1]. In this case, the elided lifetime is `'static`, so we should explicitly set the named lifetime to `'static`. [1] rust-lang/rust#129207
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #895 +/- ##
==========================================
+ Coverage 81.43% 81.90% +0.46%
==========================================
Files 97 98 +1
Lines 23877 24929 +1052
==========================================
+ Hits 19445 20417 +972
- Misses 4432 4512 +80 ☔ View full report in Codecov by Sentry. |
This was referenced Sep 5, 2024
marvinhagemeister
approved these changes
Sep 6, 2024
Contributor
marvinhagemeister
left a comment
marvinhagemeister
left a comment
There was a problem hiding this comment.
Sweet, thanks!
kuruk-mm
pushed a commit
to dcl-regenesislabs/deno_core
that referenced
this pull request
Oct 11, 2024
Due to a change in Rust nightly, the Rust linter now warns when an elided lifetime ends up being a named lifetime [1]. In this case, the elided lifetime is `'static`, so we should explicitly set the lifetime to `'static`. [1] rust-lang/rust#129207
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a change in Rust nightly, the Rust linter now warns when an elided lifetime ends up being a named lifetime [1]. In this case, the elided lifetime is
'static, so we should explicitly set the lifetime to'static.[1] rust-lang/rust#129207