Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd really like to be able to set logistic conditions with factorio-blueprint. Here's a way that appears to work nicely and has essentially no effect on setting circuit conditions.
I added a type property to CombinatorData that can be left undefined, or set to "logistic" or "circuit".
If it's left undefined, the condition will be a circuit condition.
In data generation, I added the connect_to_logistic_network property, and put in a ternary operator to switch between naming the condition property "circuit_condition" or "logistic_condition".
I added a test for setting the logistic condition and updated the documentation to make it clear that conditions can be circuit or logistic and aren't just for combinators.