Conversation
mcclurejt
force-pushed
the
4626-proxy
branch
from
6d59fd0 to
6b99690
Compare
aleph-v
suggested changes
Feb 15, 2023
Contributor
aleph-v
left a comment
aleph-v
left a comment
There was a problem hiding this comment.
Hi, thanks for your submission. I've reviewed the code and it looks good, and appears to be a very close match for the yearn asset proxy which helps a lot with ensuring security. I'm requesting changes because generally we would like to see testing on all code in this repo. In this case simply repurposing the tests for the yearn adapter with a 4626 back end would be more than enough.
Additionally, for any code without audits we'd like to have them merged into an alpha branch instead of into main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create an ERC4626 Asset Proxy using the YVaultAssetProxy as a base