Open
Conversation
Contributor
|
This needs some integration-level testing validating the withdrawals and deposits from compound are being made correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I am working on a fixed borrow protocol at component.fi
I am investigating how to add an asset proxy of compound III into element v1. The problem is that compound III acts like Aave in that cToken balance keeps increasing with time. So
deposit()orunderlying()doesn't work the same as v2 of compound.Currently, I have just written the asset proxy. Will add tests later, but wanted some eyes on if I am going in the right direction.
Basically added
yieldSharesIssuedwhich keeps track of tokens issued by the deposit() so that we can later calculateunderlying()correctly!Shoutout to @Padraic-O-Mhuiris for the idea