fix(nginx) wait for nginx reload to avoid zombies #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a unix process is spawned, the parent process must wait for its pid or the process will become a zombie after exit. This fixes the problem that the "/opt/router/sbin/router" binary leaves behing a defunct nginx process each time the config is reloaded by spawning "nginx -s reload".
|
Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it. |
Contributor
|
@felixbuenemann to the best of my knowledge, no one is actively maintaining the old components of Deis Workflow anymore. |
|
Hi @felixbuenemann and @krancour . I am from the Fork of Deis Workflow team - Hephy. https://github.com/teamhephy/ This is a good PR and we actually encountered a problem with this yesterday. Please can you make this PR against hephy-router repository and we can merge it in and get it into the first release. Here is repository for the hephy-router: https://github.com/teamhephy/router |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a unix process is spawned, the parent process must wait for its pid or the process will become a zombie after exit. This fixes the problem that the
/opt/router/sbin/routerbinary leaves behing a defunct nginx process each time the config is reloaded by spawning "nginx -s reload".Fixes #331.