Skip to content

docs: clarify language classification step in tutorial 32 #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AbraImani wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs: clarify language classification step in tutorial 32 #424

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e57ef0c
docs: clarify language classification step in tutorial 32
AbraImani Jan 20, 2026
8952db3
docs: clarify language classification step in tutorial 32
AbraImani Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tutorials/32_Classifying_Documents_and_Queries_by_Language.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,11 @@
"id": "d9fyP-ThRTue"
},
"source": [
"In this step, we configure the language classification component that will detect and route documents based on their language\n",
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The introductory sentence is missing a period at the end. It should end with "language." to be consistent with standard punctuation rules and match the style of other sentences in the documentation.

Copilot uses AI. Check for mistakes.
"\n",
"The `DocumentLanguageClassifier` takes a list of languages. The `MetadataRouter` needs a dictionary of rules. These rules specify which node to route a document to (in this case, which language-specific `DocumentWriter`), based on the document's metadata.\n",
"\n",
"The keys of the dictionary are the names of the output connections, and the values are dictionaries that follow the format of [filtering expressions in Haystack.](https://docs.haystack.deepset.ai/docs/metadata-filtering).\n"
"The keys of the dictionary are the names of the output connections, and the values are dictionaries that follow the format of [filtering expressions in Haystack.](https://docs.haystack.deepset.ai/docs/metadata-filtering)."
]
},
{
Expand Down Expand Up @@ -687,4 +689,4 @@
},
"nbformat": 4,
"nbformat_minor": 0
}
}
Loading