fix: Clear setuid/setgid bits when downloading files via scp (CVE-2026-35385)#16
Open
deepin-ci-robot wants to merge 2 commits into
Open
fix: Clear setuid/setgid bits when downloading files via scp (CVE-2026-35385)#16deepin-ci-robot wants to merge 2 commits into
deepin-ci-robot wants to merge 2 commits into
Conversation
…6-35385) When downloading files as root in legacy (-O) mode and without the -p (preserve modes) flag set, scp did not clear setuid/setgid bits from downloaded files as one might typically expect. This bug dates back to the original Berkeley rcp program. Reported by Christos Papakonstantinou of Cantina and Spearbit. Upstream commit: 487e8ac146f7d6616f65c125d5edb210519b833a Co-Authored-By: hudeng <hudeng@deepin.org>
|
TAG Bot TAG: 1%9.9p2-0deepin7 |
Contributor
Author
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/hold |
|
/integrate |
|
AutoIntegrationPr Bot |
The patch had offset 7 lines and fuzz 1 when applied. Refreshed with quilt to align hunk context with current codebase. Upstream: openssh/openssh-portable@487e8ac Generated-By: uos/glm-5.1 Co-Authored-By: hudeng <hudeng@deepin.org>
Contributor
|
/integrate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CVE-2026-35385 Fix
Vulnerability
When downloading files as root in legacy (
-O) mode and without the-p(preserve modes) flag set, scp did not clear setuid/setgid bits from downloaded files as one might typically expect. This bug dates back to the original Berkeley rcp program.Fix
Backport upstream commit 487e8ac which adds
mask |= 07000to clear setuid/setgid/sticky bits when not preserving modes.Changes
debian/patches/0038-upstream-Clear-setuid-setgid-bits-when-downloading-.patch: New patchdebian/patches/series: Add new patchdebian/changelog: Bump to 1:9.9p2-0deepin7References