Skip to content

fix: implemented explicit AbortController connection timeouts within routeParser (#53)#73

Open
prakshithamalla-art wants to merge 1 commit into
deekshithgowda85:prodfrom
prakshithamalla-art:bug-routeparser-timeout-53
Open

fix: implemented explicit AbortController connection timeouts within routeParser (#53)#73
prakshithamalla-art wants to merge 1 commit into
deekshithgowda85:prodfrom
prakshithamalla-art:bug-routeparser-timeout-53

Conversation

@prakshithamalla-art
Copy link
Copy Markdown
Contributor

Closes #53

🎯 Overview & Motivation

During target application scanning and asset discovery loops, the system routing crawler (lib/attack-pipeline/parsers/routeParser.ts) relied on standard unbounded fetch operations. If a target site contains dead links, unresponsive ports, or drops out unexpectedly, the entire background execution thread would hang indefinitely, freezing the queue pipeline.

This PR implements a robust 5000ms request timeout wrapper utilizing native AbortController signals to guarantee predictable socket rejection behavior.

🛠️ Changes Implemented

  • Engineered an isolated execution guard routine inside parseTargetRoute via native JavaScript AbortController mechanisms.
  • Configured an automatic 5000ms threshold trigger that signals a clean .abort() call on slow endpoints.
  • Wrapped tracking routines in a thorough try/catch/finally syntax block, filtering specific AbortError exception instances cleanly and freeing up active interval timers instantly.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 30, 2026

@prakshithamalla-art is attempting to deploy a commit to the Deekshith Gowda HS's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 30, 2026

Warning

Review limit reached

@prakshithamalla-art, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 41 minutes and 1 second. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 28311cb4-965d-4678-bfca-253051e9a91d

📥 Commits

Reviewing files that changed from the base of the PR and between d96a51d and b628489.

📒 Files selected for processing (1)
  • lib/attack-pipeline/parsers/routeParser.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@deekshithgowda85
Copy link
Copy Markdown
Owner

The job is failing due to a TypeScript linting error in lib/attack-pipeline/parsers/routeParser.ts at line 68:

Code
error Unexpected any. Specify a different type @typescript-eslint/no-explicit-any
Root Cause
Line 68 uses catch (error: any) which violates the @typescript-eslint/no-explicit-any rule. The any type bypasses TypeScript's type safety.

Solution
Replace the any type with a proper union type that handles both Error and unknown error types:

TypeScript
catch (error: Error | unknown) {
// Type guard to safely access error properties
const errorMessage = error instanceof Error ? error.message : String(error);
const errorName = error instanceof Error ? error.name : "Unknown";

// Check if network pipeline error matches the Abort signal trigger
if (errorName === "AbortError") {
console.error(NETWORK TIMEOUT CRITICAL EXCEPTION: Connection to ${targetUrl} aborted after exceeding ${timeoutMs}ms restriction.);
throw new Error(Pipeline socket termination: Endpoint [${targetUrl}] failed to respond within ${timeoutMs}ms.);
}

console.error(Route Discovery Endpoint Connectivity Failure [${targetUrl}]:, errorMessage);
return result;
}
Key Changes
Changed error: any to error: Error | unknown
Added type guards using instanceof Error to safely access error properties
Used String(error) as a fallback for unknown error types
This fix maintains the existing error handling logic while satisfying TypeScript's type safety requirements and the ESLint rule.

Correct the error

@deekshithgowda85
Copy link
Copy Markdown
Owner

Still ci is failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG/STABILITY — Implement explicit HTTP request timeouts inside routeParser

2 participants