Skip to content

Conversation

@Seltraeh
Copy link
Contributor

@Seltraeh Seltraeh commented Mar 2, 2025

Updated spacing, flow, organization, grammar, and readability

Seltraeh added 2 commits March 2, 2025 11:31
Updated spacing, flow, organization, grammar, and readability
The tutorial can finally get a complete noob Dev from beginning to end with little extra research or hidden steps. Good lord this took me over 2 hours to pull together, but I quality controlled it as I went along to ensure what I wrote actually happens. By the end I had a functional server. Tomorrow I'll do the client one. I'm going to bed now... lol
Copy link
Member

@arves100 arves100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general with the images (#7) it looks ok. Please fix the following errors coming from sphinx build as well:

\decompfrontier.github.io\source\pages\Tutorial\dev-server.rst:41: ERROR: Unexpected indentation. [docutils]

\decompfrontier.github.io\source\pages\Tutorial\dev-server.rst:58: ERROR: Unexpected indentation. [docutils]

\decompfrontier.github.io\source\pages\Tutorial\dev-server.rst:68: ERROR: Unexpected indentation. [docutils]

\decompfrontier.github.io\source\pages\Tutorial\dev-server.rst:75: ERROR: Unexpected indentation. [docutils]

\decompfrontier.github.io\source\pages\Tutorial\dev-server.rst:82: ERROR: Unexpected indentation. [docutils]

\decompfrontier.github.io\source\pages\Tutorial\dev-server.rst:101: ERROR: Unexpected indentation. [docutils]

Compatibility update for Sphinx and replaced the temporary vcpkg_root variable with a permanent version for later tutorials.
@Seltraeh Seltraeh requested a review from arves100 March 3, 2025 15:38
Copy link
Member

@arves100 arves100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another identation error, for the rest it looks good.

\decompfrontier.github.io\source\pages\Tutorial\dev-server.rst:98: ERROR: Unexpected indentation. [docutils]

Changed spacing to work for Sphinx
@Seltraeh Seltraeh requested a review from arves100 March 7, 2025 01:25
Copy link
Member

@arves100 arves100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks

@arves100 arves100 merged commit ed5aa70 into decompfrontier:main Mar 7, 2025
1 check passed
@Seltraeh Seltraeh deleted the patch-1 branch March 7, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants