-
Notifications
You must be signed in to change notification settings - Fork 2
Major revamp of dev-server.rst grammar #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated spacing, flow, organization, grammar, and readability
The tutorial can finally get a complete noob Dev from beginning to end with little extra research or hidden steps. Good lord this took me over 2 hours to pull together, but I quality controlled it as I went along to ensure what I wrote actually happens. By the end I had a functional server. Tomorrow I'll do the client one. I'm going to bed now... lol
arves100
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general with the images (#7) it looks ok. Please fix the following errors coming from sphinx build as well:
\decompfrontier.github.io\source\pages\Tutorial\dev-server.rst:41: ERROR: Unexpected indentation. [docutils]
\decompfrontier.github.io\source\pages\Tutorial\dev-server.rst:58: ERROR: Unexpected indentation. [docutils]
\decompfrontier.github.io\source\pages\Tutorial\dev-server.rst:68: ERROR: Unexpected indentation. [docutils]
\decompfrontier.github.io\source\pages\Tutorial\dev-server.rst:75: ERROR: Unexpected indentation. [docutils]
\decompfrontier.github.io\source\pages\Tutorial\dev-server.rst:82: ERROR: Unexpected indentation. [docutils]
\decompfrontier.github.io\source\pages\Tutorial\dev-server.rst:101: ERROR: Unexpected indentation. [docutils]
Compatibility update for Sphinx and replaced the temporary vcpkg_root variable with a permanent version for later tutorials.
arves100
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another identation error, for the rest it looks good.
\decompfrontier.github.io\source\pages\Tutorial\dev-server.rst:98: ERROR: Unexpected indentation. [docutils]
Changed spacing to work for Sphinx
arves100
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks
Updated spacing, flow, organization, grammar, and readability