feat(playwright): initialize Playwright with connection creation test#2485
Merged
viktormarinho merged 15 commits intomainfrom Feb 25, 2026
Merged
feat(playwright): initialize Playwright with connection creation test#2485viktormarinho merged 15 commits intomainfrom
viktormarinho merged 15 commits intomainfrom
Conversation
Contributor
🧪 BenchmarkShould we run the Virtual MCP strategy benchmark for this PR? React with 👍 to run the benchmark.
Benchmark will run on the next push after you react. |
Contributor
Release OptionsShould a new version be published when this PR is merged? React with an emoji to vote on the release type:
Current version: Deployment
|
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/mesh/e2e/fixtures/auth.ts">
<violation number="1" location="apps/mesh/e2e/fixtures/auth.ts:28">
P2: Waiting unconditionally for the “Sign up” toggle can time out when the form already starts in sign-up mode (the link is absent), causing the test to fail. Guard the click so it only runs when the toggle exists.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
7b4ecdf to
fe58143
Compare
fe58143 to
eb64ac3
Compare
`bun test` was picking up `apps/mesh/e2e/**/*.spec.ts` and running Playwright files through Bun's runner, causing an immediate crash. Scope the test command to `apps/mesh/src` and `packages` where all unit tests live. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
bun test directly picks up apps/mesh/e2e/*.spec.ts and crashes when Playwright APIs are called outside the Playwright runner. bun run test scopes to apps/mesh/src and packages where unit tests live. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
- Add playwright to ignoreBinaries (used via npx in e2e workflow) - Remove export from generateTestUser (only used internally by signUp) Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Initializes Playwright e2e testing in
apps/mesh/. Branches offfeat/connections-setupso it can be reviewed separately.What's included
playwright.config.ts— Chromium only, port 4000,reuseExistingServer: true(runbun run devfirst)e2e/fixtures/auth.ts—signUp()helper that creates a unique test user via the login forme2e/tests/connection-create.spec.ts— first test: sign up → enter org → connections page → create HTTP connection → assert detail pageRunning the tests
Notes
test-{timestamp}@playwright.local) — no test data cleanup neededbutton[hasText=/open/i]) may need adjustment depending on the exact home page layout — this is the first thing to validate when running against a live servernpx playwright install chromium(not committed)🤖 Generated with Claude Code
Summary by cubic
Sets up Playwright E2E tests for Mesh with a first test that signs up and creates an HTTP connection. Adds CI to run them on main and PRs, and updates unit test CI to avoid running Playwright specs.
New Features
Bug Fixes
Written for commit b91a516. Summary will update on new commits.