feat: event card avatar click handler#450
Open
braianj wants to merge 1 commit into
Open
Conversation
Deploying ui2 with
|
| Latest commit: |
412bd86
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4065420d.ui2-423.pages.dev |
| Branch Preview URL: | https://feat-event-card-avatar-click.ui2-423.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds an optional
onAvatarClickhandler toEventCard.today the creator row is a hard link to the legacy
decentraland.org/profile/accounts/<addr>URL and it sits inside the card's action area, so clicking the avatar both navigated to the legacy profile AND fired the card-level jump-in in a second tab. whenonAvatarClickis provided the row renders as a button (preventDefault+stopPropagation) and delegates navigation to the consumer — sites uses it to open its native/profile/<addr>route. without the prop the behavior is unchanged (backward compatible, optional with default).test plan
onAvatarClick, the creator link still navigates to the legacy profile URLonAvatarClick: clicking the creator name fires the handler only — no second tab, no card-level jump-inrole="button",tabIndex=0) when the handler is provided