chore: upgrade MUI to v9 and Storybook to v10#370
Open
braianj wants to merge 7 commits into
Open
Conversation
- Upgrade Storybook to 9.0.18 and update addons/config - Upgrade MUI to 7.3.7 and remove deep imports / deprecated entrypoints - Fix stories typings for SB9 (blocks, ArgTypes, defaultValue summaries) - Fix build/test configs (ignore dist tests in Jest) - Export missing components (AssetImage, Atlas) and add dclButton namespace
Deploying ui2 with
|
| Latest commit: |
0bae546
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e640f61e.ui2-423.pages.dev |
| Branch Preview URL: | https://feat-upgrade-mui-and-storybo.ui2-423.pages.dev |
- Replace extendTheme with createTheme({ cssVariables: true, colorSchemes })
- Update ThemeProvider from CssVarsProvider to MuiThemeProvider
- Update Storybook preview to use useColorScheme hook for theme switching
- Migrate styled imports from @emotion/styled to @mui/material
- Add shouldForwardProp to prevent custom props from reaching DOM
- Add color fallbacks for RarityBadge when theme.palette.rarities is undefined
braianj
changed the title
cyaiox
reviewed
Jan 30, 2026
cyaiox
reviewed
Jan 30, 2026
…d-storybook # Conflicts: # .storybook/main.ts # .storybook/preview.ts # jest.config.js # package-lock.json # package.json # src/components/Atlas/Atlas.stories.tsx # src/components/Blockie/Blockie.styled.ts # src/components/Blockie/Blockie.tsx # src/components/CatalogCard/CatalogCard.styled.ts # src/components/JumpIn/JumpIn.stories.tsx # src/components/Modal/DownloadModal/DownloadModal.stories.tsx # src/components/Modal/DownloadModal/index.ts # src/components/Modal/index.ts # src/components/Navbar/MainMenu/MainMenu.styled.tsx # src/components/Navbar/Navbar.styled.ts # src/components/Navbar/SubMenu/SubMenu.styled.ts # src/components/Profile/Profile.styled.ts # src/components/RarityBadge/RarityBadge.stories.tsx # src/components/RarityBadge/RarityBadge.styled.ts # src/components/UserMenu/UserMenu.styled.tsx # src/components/WearablePreview/AnimationControls/AnimationControls.styled.ts # src/index.ts # src/theme/index.ts # src/theme/provider.tsx
- @mui/material and @mui/icons-material 7.3.7 -> 9.1.0 (v8 was skipped upstream) - storybook packages 10.1.11 -> 10.4.3 - migrate removed system props (display, gap, textAlign, fontWeight, fontSize) to sx - Menu MenuListProps -> slotProps.list - drop custom docs page in Atlas stories (addon-docs/blocks import broke the preview chunk; autodocs covers it)
braianj
changed the title
- build one theme per mode again: component overrides were receiving the light palette in both modes, breaking every styled component in dark - migrate Button compound CSS classes removed in MUI 9 (textSecondary, containedPrimary, etc.) to variant + color atomic classes in theme overrides, ChainSelector, FooterLanding, DownloadButton, JumpIn and ManaBalances - wrap UserMenu actions in MenuList (MenuItem outside Menu/MenuList throws in MUI 9) - migrate backgrounds addon config to Storybook 10 API (options + globals) in preview, EventSmallCard and Icons stories - drop actions argTypesRegex: SB10 injects spies for onClose/onBack that made Modal render back/close buttons production does not show - drop ScenesTable red background override that SB7 never applied Verified by pixel-diffing all 331 stories against ui2.decentraland.org: light 331/331 identical; dark 305/331 identical, remaining 26 are live external content (Atlas tiles fetch, WearablePreview 3D iframe, Beehiiv embed) re-verified identical with longer waits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
^9.1.0range; v8 was skipped upstream)createThemewith CSS variables (colorSchemeslight/dark,colorSchemeSelector: data);light/darknow share a single theme and mode is controlled viadefaultMode/useColorSchemesx(Banner, SceneRow, Button/DownloadButton/SceneCard stories),MenuListProps->slotProps.list(LanguageDropdown)HiddenandUnstable_Grid2re-exports (deleted in MUI 7+)moduleResolution: bundlerin tsconfig so Storybook 10 type exports resolvesatisfies Meta,defaultValue.summaryas string) and drop the custom docs page in Atlas stories (theaddon-docs/blocksimport broke the preview chunk;autodocscovers it)AssetImage,Atlas) and adddclButtonnamespaceVerified:
tscbuild, unit tests, lint, package.json lint andbuild-storybookall green. All 331 stories render without errors in both light and dark modes, including interactive flows (navbar submenus, user menu panel, download modals, Atlas tile map).