Fix: bindActions dropped ν-net join matchSpec (NU-030)#43
Merged
Conversation
Follow-up to 2.10.3. `PetriNet.bindActions` rebuilds every transition via `rebuildWithAction` to attach its action, but never carried `matchSpec` forward — a third drop site missed by the 2.10.3 composition fix. A net composed with an intact ν-net join lost its correlation the moment actions were bound, reverting a correlated join-by-id to a plain FIFO AND join at runtime and pairing tokens by arrival order across overlapping fork/join generations. - `rebuildWithAction` now carries the transition's `matchSpec` as-is. bindActions does not rename places, so no remap is applied (unlike `rebuildWithName`). - Regression tests: `bindActions_preservesMatchSpec` (structural) and `bindActions_matchedJoin_correlatesByName_notFifo` (behavioral). - Bump java version to 2.10.4; CHANGELOG updated.
debe
added a commit
that referenced
this pull request
Jul 2, 2026
…(NU-030) Cross-language rollout of the bindActions matchSpec fix (PR #43, Java). rebuildWithAction attaches an action by rebuilding the transition; the TypeScript path dropped the join's matchSpec, reverting a correlated join-by-id to a plain FIFO AND join once actions were bound (pairing tokens by arrival order across fork/join generations). A bind renames no places, so the match is carried as-is, unlike the compose/rename path. - typescript: rebuildWithAction now carries matchSpec; structural + behavioral regression tests (both executors). - rust: rebuild_with_action already carried it; added structural (core) + behavioral (runtime, both backends) regression guards. - python: pytest that a bound matched join correlates by name, not FIFO (rides on the Rust runtime). - coordinated version bump: TS 2.10.4, Rust 3.4.4, Python 2.13.2 (Java 2.10.4 from PR #43); CHANGELOG entry made cross-language.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to 2.10.3.
PetriNet.bindActionsrebuilds every transition viarebuildWithActionto attach its action, but never carriedmatchSpecforward — a third drop site missed by the 2.10.3 composition fix.A net composed with an intact ν-net join lost its correlation the moment actions were bound, reverting a correlated join-by-id to a plain FIFO AND join at runtime and pairing tokens by arrival order across overlapping fork/join generations.
rebuildWithActionnow carries the transition'smatchSpecas-is. bindActions does not rename places, so no remap is applied (unlikerebuildWithName).bindActions_preservesMatchSpec(structural) andbindActions_matchedJoin_correlatesByName_notFifo(behavioral).