Removed ddx_driver.f90 from the ddX library source files#177
Open
robin-dahl wants to merge 4 commits into
Open
Removed ddx_driver.f90 from the ddX library source files#177robin-dahl wants to merge 4 commits into
robin-dahl wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes
src/ddx_driver.f90from theddx_librarysource list inmeson.buildddx_driver.f90defines a Fortranprogram main, so it should only be compiled as the source for theddX_execexecutable. Including it in the library means the library may also contain an executable entry point, which can conflict with test executables that define their ownprogram main.Keeping
ddx_driver.f90only in theddX_execexecutable target matches its role as a driver program and keeps the library limited to reusable ddX implementation sources.