Skip to content

BMIM Cl bond formation benchmark#334

Merged
ElliottKasoar merged 7 commits intoddmms:mainfrom
PythonFZ:main
Mar 4, 2026
Merged

BMIM Cl bond formation benchmark#334
ElliottKasoar merged 7 commits intoddmms:mainfrom
PythonFZ:main

Conversation

@PythonFZ
Copy link
Contributor

@PythonFZ PythonFZ commented Feb 2, 2026

Pre-review checklist for PR author

PR author must check the checkboxes below when creating the PR.

Summary

This benchmark introduces a check for the formation of a Cl-C bond in the ionic liquid BMIM Cl.
Some models show a bond formation which should not happen.
The test runs

  1. Build BMIM Cl system
  2. Run geometry optimization
  3. Run 5 ps MD
  4. Compute C-Cl RDF
  5. Check if the RDF shows bond lengths shorter than 2 A (furthest covalent bond distance), if so mark as failed.

Added https://github.com/zincware/molify for creating initial configurations to the list of depedencies.
This package is the successor of https://github.com/zincware/rdkit2ase
which is already included via
https://github.com/basf/mlipx/blob/9ee4a5453aeaafc3109c2cac399de0363249367b/pyproject.toml#L21

Linked issue

Resolves #

Progress

  • Calculations
  • Analysis
  • Application
  • Documentation

Testing

image image

@ElliottKasoar ElliottKasoar added the new benchmark Proposals and suggestions for new benchmarks label Feb 2, 2026
Copy link
Collaborator

@ElliottKasoar ElliottKasoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I'm testing it now, but overall it looks great! Please can you rebase as I think there are conflicts with uv.lock due to recently merged changes

@PythonFZ
Copy link
Contributor Author

Thanks for this! I'm testing it now, but overall it looks great! Please can you rebase as I think there are conflicts with uv.lock due to recently merged changes

I hope to have addressed all comments and rebased onto main

Copy link
Collaborator

@ElliottKasoar ElliottKasoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @PythonFZ!

I may return to this with some minor requests following some changes being added in #360, but I think this looks great!

@ElliottKasoar ElliottKasoar merged commit 05be482 into ddmms:main Mar 4, 2026
7 checks passed
kuryla pushed a commit to kuryla/ml-peg-omol that referenced this pull request Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new benchmark Proposals and suggestions for new benchmarks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants