Skip to content

Fix fee calculation in bitcoind client #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcdpr merged 4 commits into from
Apr 11, 2026
Merged

Fix fee calculation in bitcoind client #25

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cb85305
Fix fee calculation in bitcoind client
parasyte Apr 11, 2026
9e0533a
Fix type inference fail and deprecation warning
parasyte Apr 11, 2026
5f7c65b
Revert formatting changes
parasyte Apr 11, 2026
7cb0ad6
Type inference is pretty bad when composing traits
parasyte Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions crates/esploda/src/bitcoind/tx.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,15 +200,22 @@ impl Transaction {
///
/// # Panics
///
/// Asserts that `previous_outputs` and `self.inputs` have the same number of non-coinbase TXOs.
/// - Asserts that the computed `fee` is not negative.
/// - Asserts that `previous_outputs` and `self.inputs` have the same number of non-coinbase
/// TXOs.
///
/// [`esplora::Transaction`]: crate::esplora::Transaction
pub fn into_esplora(
self,
block_height: u32,
previous_outputs: Vec<TxOut>,
) -> crate::esplora::Transaction {
let fee = previous_outputs.iter().map(|txo| txo.value).sum();
let prev_outputs: Decimal = previous_outputs.iter().map(|txo| txo.value).sum();
let outputs: Decimal = self.outputs.iter().map(|txo| txo.value).sum();

let fee = prev_outputs - outputs;
assert!(!fee.is_sign_negative(), "Fee must never be negative");

let mut previous_outputs = previous_outputs.into_iter();
let inputs = self
.inputs
Expand Down
Loading