Skip to content

Fix ShellCheck SC2155 warning in Bootstrap/stow.sh#4

Merged
dbmrq merged 2 commits into
copilot/cleanup-dotfiles-reliability-fixesfrom
copilot/fix-lint-step-issue
Feb 16, 2026
Merged

Fix ShellCheck SC2155 warning in Bootstrap/stow.sh#4
dbmrq merged 2 commits into
copilot/cleanup-dotfiles-reliability-fixesfrom
copilot/fix-lint-step-issue

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 16, 2026

ShellCheck was failing CI with SC2155 warning on line 55 of Bootstrap/stow.sh.

Change

Separated variable declaration from command substitution assignment:

# Before
local os=$(uname -s)

# After
local os
os=$(uname -s)

This avoids masking the return value of uname per ShellCheck best practices.

Original prompt

Pull Request: #2

The lint step is failing on this


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: dbmrq <15813674+dbmrq@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix lint step failure in pipeline Fix ShellCheck SC2155 warning in Bootstrap/stow.sh Feb 16, 2026
Copilot AI requested a review from dbmrq February 16, 2026 16:28
@dbmrq dbmrq marked this pull request as ready for review February 16, 2026 16:31
Copilot AI review requested due to automatic review settings February 16, 2026 16:32
@dbmrq dbmrq merged commit 1fb28a5 into copilot/cleanup-dotfiles-reliability-fixes Feb 16, 2026
1 check passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a CI failure caused by ShellCheck SC2155 in Bootstrap/stow.sh by separating the local declaration from the command-substitution assignment, preserving the uname exit status per ShellCheck guidance.

Changes:

  • Split local os=$(uname -s) into local os followed by os=$(uname -s) inside get_packages().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants