Skip to content

Reconcile cross-platform fixes and resolve review comments#3

Merged
dbmrq merged 2 commits into
copilot/cleanup-dotfiles-reliability-fixesfrom
copilot/reconcile-open-prs-and-fix-comments
Feb 16, 2026
Merged

Reconcile cross-platform fixes and resolve review comments#3
dbmrq merged 2 commits into
copilot/cleanup-dotfiles-reliability-fixesfrom
copilot/reconcile-open-prs-and-fix-comments

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 16, 2026

Consolidates changes from PR #2 (cross-platform reliability fixes) and addresses 3 unresolved review comments.

Review comment fixes

Bootstrap/stow.sh: Compute uname -s once before loop instead of per-iteration

local os=$(uname -s)
for dir in */; do
    if [[ "$os" != "Darwin" ]]; then
        # ...

Zsh/.zprofile: Re-add EDITOR/VISUAL exports for non-interactive login shells

export EDITOR='vim'
export VISUAL="$EDITOR"

.shell_common will override these with nvim when sourced by interactive shells.

README.md: Update platform description to reflect that .zshrc is now cross-platform, not macOS-only.

Included from PR #2

  • Cross-platform Homebrew detection (Apple Silicon + Intel)
  • Move .shell_common sourcing before modern CLI tools in .zshrc
  • BSD-compatible du flags (-d 1 vs --max-depth=1)
  • zipr function with argument validation
  • Git aliases: push.default = simple, discard = restore --
  • Skip macOS-only packages on Linux in bootstrap
Original prompt

Pull Request: #2

There are two open prs in this repo. I want to reconcile both into one and fix all of copilot's unresolved comments.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: dbmrq <15813674+dbmrq@users.noreply.github.com>
Copilot AI changed the title [WIP] Reconcile open PRs and resolve copilot comments Reconcile cross-platform fixes and resolve review comments Feb 16, 2026
Copilot AI requested a review from dbmrq February 16, 2026 16:09
@dbmrq dbmrq requested review from Copilot and removed request for dbmrq February 16, 2026 16:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reconciles cross-platform reliability fixes from PR #2 and addresses 3 unresolved review comments to improve shell configuration portability and bootstrap script efficiency.

Changes:

  • Re-add EDITOR/VISUAL exports to .zprofile for non-interactive login shells (vim as default, overridden by .shell_common for interactive shells with nvim detection)
  • Optimize bootstrap script by computing uname -s once before loop instead of per-iteration
  • Clarify README platform description to reflect that .zshrc is cross-platform, not macOS-only

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
Zsh/.zprofile Re-adds EDITOR/VISUAL exports for non-interactive login shells
Bootstrap/stow.sh Optimizes uname call by computing once before loop
README.md Updates platform description to clarify .zshrc is cross-platform

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dbmrq dbmrq marked this pull request as ready for review February 16, 2026 16:18
@dbmrq dbmrq merged commit 66c1a3f into copilot/cleanup-dotfiles-reliability-fixes Feb 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants