Reconcile cross-platform fixes and resolve review comments#3
Merged
dbmrq merged 2 commits intoFeb 16, 2026
Conversation
Co-authored-by: dbmrq <15813674+dbmrq@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Reconcile open PRs and resolve copilot comments
Reconcile cross-platform fixes and resolve review comments
Feb 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reconciles cross-platform reliability fixes from PR #2 and addresses 3 unresolved review comments to improve shell configuration portability and bootstrap script efficiency.
Changes:
- Re-add EDITOR/VISUAL exports to
.zprofilefor non-interactive login shells (vim as default, overridden by.shell_commonfor interactive shells with nvim detection) - Optimize bootstrap script by computing
uname -sonce before loop instead of per-iteration - Clarify README platform description to reflect that
.zshrcis cross-platform, not macOS-only
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Zsh/.zprofile | Re-adds EDITOR/VISUAL exports for non-interactive login shells |
| Bootstrap/stow.sh | Optimizes uname call by computing once before loop |
| README.md | Updates platform description to clarify .zshrc is cross-platform |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
66c1a3f
into
copilot/cleanup-dotfiles-reliability-fixes
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates changes from PR #2 (cross-platform reliability fixes) and addresses 3 unresolved review comments.
Review comment fixes
Bootstrap/stow.sh: Compute
uname -sonce before loop instead of per-iterationZsh/.zprofile: Re-add EDITOR/VISUAL exports for non-interactive login shells
.shell_commonwill override these with nvim when sourced by interactive shells.README.md: Update platform description to reflect that
.zshrcis now cross-platform, not macOS-only.Included from PR #2
.shell_commonsourcing before modern CLI tools in.zshrcduflags (-d 1vs--max-depth=1)ziprfunction with argument validationpush.default = simple,discard = restore --Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.