ci: fix electron prebuild workflow (verified green on Linux)#1127
Merged
Conversation
…ed chrome-sandbox)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to the build workflow from #1125 so it actually produces + verifies binaries (validated: Linux x64/arm64 green under Electron 42.2.0):
ELECTRON_DISABLE_SANDBOX=1for the Linux verify (CI has no root-owned chrome-sandbox).package.jsonvia Node's LOAD_AS_FILE rule).Windows jobs still fail at the build step (V8 14 / MSVC) - separate.