feat: numpy 2.x compatibility#240
Open
filimarc wants to merge 11 commits into
Open
Conversation
- Relax numpy version pins from ~=1.x to >=1.x in bsb-core and bsb-arbor - Replace np.array(..., copy=False) with np.asarray() across bsb-core and bsb-hdf5 (semantics changed in numpy 2.0) - Remove np.VisibleDeprecationWarning assertion in test_voxels (removed in numpy 2.0) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- numpy~=1.21 -> numpy>=1.21 in arborize and nrn-patch - bsb-core~=7.0 -> bsb-core~=7.4 in arborize and sphinxext-bsb Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Allows quantities 0.16.x, compatible with elephant 1.2.0. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…2.0) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
np.array(..., copy=False) without subok=True stripped the Chunk subclass; bare arithmetic preserved it, causing Chunk.__le__ to trigger on coordinate comparisons. np.asarray() strips the subclass correctly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
==========================================
+ Coverage 80.54% 82.89% +2.34%
==========================================
Files 188 135 -53
Lines 18179 15414 -2765
Branches 2174 1834 -340
==========================================
- Hits 14642 12777 -1865
+ Misses 2977 2195 -782
+ Partials 560 442 -118 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
close #237
Test plan
Generated with Claude Code
📚 Documentation preview 📚: https://nrn-patch--240.org.readthedocs.build/en/240/
📚 Documentation preview 📚: https://arborize--240.org.readthedocs.build/en/240/
📚 Documentation preview 📚: https://bsb-otel--240.org.readthedocs.build/en/240/