Small Fixes#204
Conversation
Signed-off-by: BuffMcBigHuge <marco@bymar.co>
ryanontheinside
left a comment
There was a problem hiding this comment.
This needs a small fix before merge.\n\nThe new inish() path in AlmostReadyDialog calls onContinue(...) and then immediately calls onClose(). All current callers wire onClose to setPending(null), while commitUploadedTrack still intentionally keeps pending until upload success so failed encodes/uploads can be retried. With this PR, pressing Start dismisses the dialog and clears the trimmed upload buffer before the async upload has succeeded; if the upload fails, the user only gets a status message and cannot retry the same trimmed selection.\n\nPlease close the dialog only after commitUploadedTrack succeeds, or otherwise preserve/restore retry state on failure.
|
Thanks @ryanontheinside — good catch. Fixed in The dialog no longer calls The double-submit guard ( |
Signed-off-by: BuffMcBigHuge <marco@bymar.co>
Fix to vae spam logging, fix to modal handling of uploaded track.