Installer follow-ups: shellcheck CI, docs, venv ownership#2
Open
davidj4tech wants to merge 1 commit into
Open
Conversation
- Add .github/workflows/shellcheck.yml so installer regressions get caught in CI. Runs on push to main and on PRs. - Update docs/INSTALL.md to document the new fresh-install flow (run, edit, --update), the loosened unit discovery (any unit in ops/systemd/ with an [Install] section), and the new --uninstall / --uninstall --purge modes. - chown the Python venv to sacred:sacred after Phase 4. Services run as sacred, so leaving the venv root-owned breaks any post-install pip work from just recipes or hooks. - Add CHANGELOG entry. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1. Three independent fixes bundled together:
.github/workflows/shellcheck.ymlrunsshellcheck -S warningonscripts/for every push to main and every PR. Verified locally: currentscripts/install.shis clean at warning level.docs/INSTALL.mdnow documents (a) the new fresh-install flow — run installer, edit/etc/sacred-brain/*, then--updateto start; (b) that all units inops/systemd/get installed, not a hardcoded subset; (c) the new--uninstall/--uninstall --purgemodes.chown -R sacred:sacred "$REPO_DIR/.venv". Services run assacred, so leaving the venv root-owned breaks any post-installpipoperation invoked from ajustrecipe or hook running as that user.Also adds a CHANGELOG entry under "Unreleased".
Test plan
ls -ld /opt/sacred-brain/.venvshowssacred sacredjust <recipe-that-pips>works without sudo from thesacreduserdocs/INSTALL.mdQuick Start steps reproduce a working install end-to-end🤖 Generated with Claude Code