Added delimiter sniffing (comma, tab, semicolon)#81
Open
yconst wants to merge 1 commit intodavedelong:masterfrom
Open
Added delimiter sniffing (comma, tab, semicolon)#81yconst wants to merge 1 commit intodavedelong:masterfrom
yconst wants to merge 1 commit intodavedelong:masterfrom
Conversation
Author
|
Good point about NEWLINE. Do you think the assertion is required? _sniffDelimiter() will assign to _delimiter one of COMMA, TAB or SEMICOLON in any case. |
Owner
|
The assertion is definitely needed, since they could invoke the method with |
|
Hi guys, I was wondering why this PR was never merged? After some quick tests over different CSV files separated by comma or semi colon, it seems to be working as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a routine to detect the correct delimiter among comma, semicolon and tab. Replaced the default use of a comma as a delimiter with delimiter sniffing in method calls. Newline is passed as a dummy parameter to denote that we want delimiter sniffing.