Parsing shouldn't end when the stream has no bytes available#46
Open
MihaiDamian wants to merge 2 commits intodavedelong:masterfrom
Open
Parsing shouldn't end when the stream has no bytes available#46MihaiDamian wants to merge 2 commits intodavedelong:masterfrom
MihaiDamian wants to merge 2 commits intodavedelong:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser currently stops if the input stream has no available bytes to read. This seems incorrect as parsing should normally continue until the stream is closed, at an end or when an error has occurred. If hasBytesAvailable returns no it doesn't imply any of these cases, it could just be that the input stream is not yet ready to hand out data.
I encountered this limitation while trying to set up a producer-consumer relation between a network operation that downloaded a CSV and CHCSVParser. Because of network delays the parser can often read from the stream faster than the network operation can write.
The solution in this pull request is to wait in _loadMoreIfNecessary until further data is available, the stream ends or parsing is canceled.