Skip to content

Added merge strategy explanation#2233

Merged
bereng merged 1 commit intomainfrom
mergeStrategyCC-main
Feb 26, 2026
Merged

Added merge strategy explanation#2233
bereng merged 1 commit intomainfrom
mergeStrategyCC-main

Conversation

@bereng
Copy link
Collaborator

@bereng bereng commented Feb 16, 2026

What is the issue

We need to document the merge strategy we follow for CC development.

What does this PR fix and why was it fixed

Kick starts documentation on the matter which we build upon later on.

@github-actions
Copy link

github-actions bot commented Feb 16, 2026

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

Copy link
Member

@k-rus k-rus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for starting explicitly describing the current practice. I have a number of comments to make few points more clear.

Copy link
Member

@djatnieks djatnieks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions, but I think this is a good overview - thanks for putting it together.

Maybe a nitpick, but there should be a CNDB ticket for all of our changes, and the PR (and maybe commit comment) should include the ticket number, I believe.

@bereng
Copy link
Collaborator Author

bereng commented Feb 17, 2026

Thanks @djatnieks reading your comment I see I don't want to duplicate the PR checklist here. Which triggered me to realize I should have titled my section 'Merging' instead of 'Contributing'. Wdyt?

Copy link
Member

@djatnieks djatnieks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for doing this!

@djatnieks djatnieks requested a review from k-rus February 18, 2026 16:18
Copy link
Member

@k-rus k-rus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused with current step formulations, see my comment.

Do this instructions suggest that any commit to main should be cherry-picked to main-5.0.

Or is the purpose of this document to explain how to merge commits from main to main-5.0?

@bereng bereng force-pushed the mergeStrategyCC-main branch from 88b856b to 563dd94 Compare February 19, 2026 09:51
Copy link
Member

@k-rus k-rus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we will iterate on the instructions when necessary.

@bereng bereng force-pushed the mergeStrategyCC-main branch from d8b8127 to fd6c8d4 Compare February 26, 2026 07:26
@sonarqubecloud
Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-2233 rejected by Butler


4 regressions found
See build details here


Found 4 new test failures

Test Explanation Runs Upstream
o.a.c.index.sai.cql.VectorCompaction100dTest.testOneToManyCompaction[eb false] REGRESSION 🔴 0 / 15
o.a.c.index.sai.cql.VectorKeyRestrictedOnPartitionTest.partitionRestrictedWidePartitionBqCompressedTest[ec false] (compression) NEW 🔵🔴 0 / 15
o.a.c.index.sai.cql.VectorSiftSmallTest.testMultiSegmentBuild[db false] NEW 🔴 0 / 15
o.a.c.net.ConnectionTest.testTimeout REGRESSION 🔴 1 / 15

Found 6 known test failures

@bereng bereng merged commit 57db205 into main Feb 26, 2026
2 of 4 checks passed
@bereng bereng deleted the mergeStrategyCC-main branch February 26, 2026 08:41
@bereng
Copy link
Collaborator Author

bereng commented Feb 26, 2026

Thx all for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants