Conversation
Checklist before you submit for review
|
k-rus
left a comment
There was a problem hiding this comment.
Thank you for starting explicitly describing the current practice. I have a number of comments to make few points more clear.
djatnieks
left a comment
There was a problem hiding this comment.
A few suggestions, but I think this is a good overview - thanks for putting it together.
Maybe a nitpick, but there should be a CNDB ticket for all of our changes, and the PR (and maybe commit comment) should include the ticket number, I believe.
|
Thanks @djatnieks reading your comment I see I don't want to duplicate the PR checklist here. Which triggered me to realize I should have titled my section 'Merging' instead of 'Contributing'. Wdyt? |
djatnieks
left a comment
There was a problem hiding this comment.
Looks good, thanks for doing this!
k-rus
left a comment
There was a problem hiding this comment.
I am confused with current step formulations, see my comment.
Do this instructions suggest that any commit to main should be cherry-picked to main-5.0.
Or is the purpose of this document to explain how to merge commits from main to main-5.0?
88b856b to
563dd94
Compare
k-rus
left a comment
There was a problem hiding this comment.
LGTM, we will iterate on the instructions when necessary.
d8b8127 to
fd6c8d4
Compare
|
❌ Build ds-cassandra-pr-gate/PR-2233 rejected by Butler4 regressions found Found 4 new test failures
Found 6 known test failures |
|
Thx all for the review. |



What is the issue
We need to document the merge strategy we follow for CC development.
What does this PR fix and why was it fixed
Kick starts documentation on the matter which we build upon later on.