CNDB-13303: Made warn log regarding obsolete property less spammy.#2229
Open
MSpryszynski wants to merge 1 commit intomainfrom
Open
CNDB-13303: Made warn log regarding obsolete property less spammy.#2229MSpryszynski wants to merge 1 commit intomainfrom
MSpryszynski wants to merge 1 commit intomainfrom
Conversation
Checklist before you submit for review
|
20c5812 to
5a2f70f
Compare
…configuring threshold for repetition per property.
5a2f70f to
20cf772
Compare
|
❌ Build ds-cassandra-pr-gate/PR-2229 rejected by Butler4 regressions found Found 4 new test failures
Found 4 known test failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Made warn log regarding obsolete property less spammy by configuring threshold for repetition per property.
What is the issue
There are reoccurring logs "Ignoring obsolete property nodesync" which provide no context other than that this property is still being used.
Fixes https://github.com/riptano/cndb/issues/13303
What does this PR fix and why was it fixed
Implements mechanism that allow logging single obsolete property once per 30s. It should significantly decrease number of logs and still be equally useful as we do have information that somebody is using this obsolete property.