Conversation
Checklist before you submit for review
|
driftx
requested changes
Feb 10, 2026
driftx
left a comment
There was a problem hiding this comment.
Left some comments around "if a DELETE statement delete multiple partition rows, the metric will be incremented only once" but I'm also not sure if that's the behavior we want. Maybe we do want to increment for each partition? I didn't find anything in the issue regarding this.
src/java/org/apache/cassandra/cql3/statements/DeleteStatement.java
Outdated
Show resolved
Hide resolved
driftx
reviewed
Feb 13, 2026
driftx
approved these changes
Feb 20, 2026
driftx
left a comment
There was a problem hiding this comment.
Looks good, don't forget to update the description.
|
❌ Build ds-cassandra-pr-gate/PR-2223 rejected by Butler5 regressions found Found 5 new test failures
Found 3 known test failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What is the issue
There are no metrics available to track the DELETE statements received from the clients
What does this PR fix and why was it fixed
A new per table metric called "DeleteRequests" is added.