Skip to content

CNDB-15670: Add Metric for DELETE Requests#2223

Merged
kathirsvn merged 14 commits intomainfrom
CNDB-15670
Feb 23, 2026
Merged

CNDB-15670: Add Metric for DELETE Requests#2223
kathirsvn merged 14 commits intomainfrom
CNDB-15670

Conversation

@kathirsvn
Copy link

@kathirsvn kathirsvn commented Feb 9, 2026

What is the issue

There are no metrics available to track the DELETE statements received from the clients

What does this PR fix and why was it fixed

A new per table metric called "DeleteRequests" is added.

  • For every DELETE statement from the client, the new metric will be incremented
  • For a batch of DELETEs, the metric will be incremented for each DELETE statement in the batch
  • Even if more than one row is deleted by a DELETE statement, the delete requests metric will be incremented only once

@github-actions
Copy link

github-actions bot commented Feb 9, 2026

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@kathirsvn kathirsvn self-assigned this Feb 9, 2026
@kathirsvn kathirsvn marked this pull request as ready for review February 9, 2026 20:59
@driftx driftx self-requested a review February 9, 2026 21:03
Copy link

@driftx driftx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments around "if a DELETE statement delete multiple partition rows, the metric will be incremented only once" but I'm also not sure if that's the behavior we want. Maybe we do want to increment for each partition? I didn't find anything in the issue regarding this.

@kathirsvn kathirsvn requested a review from driftx February 18, 2026 20:37
Copy link

@driftx driftx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, don't forget to update the description.

@sonarqubecloud
Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-2223 rejected by Butler


5 regressions found
See build details here


Found 5 new test failures

Test Explanation Runs Upstream
o.a.c.db.ColumnFamilyStoreTest.testDiscardSSTables REGRESSION 🔴 0 / 13
o.a.c.index.sai.cql.VectorCompaction100dTest.testPQRefine[ec false] REGRESSION 🔴 0 / 13
o.a.c.index.sai.cql.VectorCompaction2dTest.testZeroOrOneToManyCompaction[ca false] (compression) REGRESSION 🔴🔴 0 / 13
o.a.c.index.sai.cql.VectorKeyRestrictedOnPartitionTest.partitionRestrictedTest[db false false] (compression) REGRESSION 🔴🔵 0 / 13
o.a.c.index.sai.cql.VectorSiftSmallTest.testMultiSegmentBuild[ed false false] REGRESSION 🔴 0 / 13

Found 3 known test failures

@kathirsvn kathirsvn merged commit 12a22bb into main Feb 23, 2026
2 of 4 checks passed
@kathirsvn kathirsvn deleted the CNDB-15670 branch February 23, 2026 17:45
@kathirsvn kathirsvn changed the title Add Metric for DELETE Requests CNDB-15670: Add Metric for DELETE Requests Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants