CNDB -15904: Move NeworkTopologyStrategy to use NoSpamLogger during initialization

[scottfines]

Move the initialization log message in NetworkTopologyStrategy to use NoSpamLogger.

Summary
NetworkTopologyStrategy logs the datacenter configuration during initialization of Keyspace data, probably because it was useful information and the Keyspace information doesn't get constructed all that often. But in CNDB, it gets reconstructed every time data is deserialized from etcd. The end result is spamming the CNDB process logs, especially during SSTable cleanup tasks. This change reduces the spam effect to once every 10 minutes.

This resolves https://github.com/riptano/cndb/issues/15904

[github-actions]

Checklist before you submit for review

• This PR adheres to the Definition of Done
• Make sure there is a PR in the CNDB project updating the Converged Cassandra version
• Use NoSpamLogger for log lines that may appear frequently in the logs
• Verify test results on Butler
• Test coverage for new/modified code is > 80%
• Proper code formatting
• Proper title for each commit staring with the project-issue number, like CNDB-1234
• Each commit has a meaningful description
• Each commit is not very long and contains related changes
• Renames, moves and reformatting are in distinct commits
• All new files should contain the DataStax copyright header instead of the Apache License one

[scottfines]

The unticketed test failure(PreviewRepairCoordinatorTimeoutTest) is a known issue with a flaky test. Here is the GitHub issue for the test (butler's GH credentials are not currently working, so this serves as a TODO to remind me to attach this in butler when it is fixed again)

https://github.com/riptano/cndb/issues/14687

[scottfines]

A note on testing here

It's nontrivial to write an explicit test about whether or not a log message appears "enough times". However, the constructor itself is well tested for functionality reasons, particularly in NetworkTopologyStrategyTest. In the original (unmodified) version, that test emits 17 log messages about the configured replicas. After the change, it emits 8--one message for each actual change in topology. So we should have some reasonable faith that this branch is tested, and does what it says, even though it does not have an explicit test of its own.

[michaelsembwever]

how's the PR checklist going ?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[cassci-bot]

❌ Build ds-cassandra-pr-gate/PR-2191 rejected by Butler

---

4 regressions found
See build details here

---

Found 4 new test failures

Test	Explanation	Runs	Upstream
o.a.c.distributed.test.AbortedQueryLoggerTest.testLogsReadMetrics	REGRESSION	🔴🔵	0 / 8
o.a.c.index.sai.cql.VectorCompaction100dTest.testCompactionWithEnoughRowsForPQAndDeleteARow[db true]	REGRESSION	🔴⚪	0 / 8
o.a.c.index.sai.cql.VectorLocalTest.multipleNonAnnSegmentsTest[ec true] (compression)	REGRESSION	🔴🔵	0 / 8
o.a.c.index.sai.cql.VectorSiftSmallTest.testSiftSmall[dc false]	REGRESSION	🔴⚪	0 / 8

---

Found 3 known test failures

[michaelsembwever]

cndb ci results look good. https://github.com/riptano/cndb/pull/16508

please make sure not to forget anything on the checklist and def of done. (ask if there's anything uncertain)