Fixing events firing#1835
Draft
be-smith wants to merge 4 commits into
Draft
Conversation
…` in Bokeh `js_on_change` callbacks, where no DOM `event` object exists. Replaced with `cb_obj.value ?? cb_obj.text` to correctly read from the Bokeh model regardless of widget type (TextInput or Div).
datalab
 |
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
bes/async_block_events_fix
|
| Run status |
|
| Run duration | 23m 13s |
| Commit |
|
| Committer | Ben Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
0
|
 |
0
|
 |
522
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Events weren't firing properly for some use cases after the async changes. This should fix them. Resovles #1834