Push provider contact roles to salesforce on changes to those roles.#1534
Open
svogt0511 wants to merge 16 commits into
Open
Push provider contact roles to salesforce on changes to those roles.#1534svogt0511 wants to merge 16 commits into
svogt0511 wants to merge 16 commits into
Conversation
…h changed contact data to salesforce.
…one contact in provider.contacts that matches the given email.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Make sure any changes to provider contact roles are pushed to Salesforce.
closes: datacite/datacite#2207
Approach
Providers have contacts which can be given roles in the provider organization: billing contact, voting contact, technical contact, etc. When those roles are changed (either via the API or Fabrica), the contact is not always updated in salesforce to reflect those role changes.
This change makes sure that role changes are reflected in the contacts table (not just the provider/allocator table), and as a result of those changes, a sync message is sent to salesforce to update the contacts there, as well.
Open Questions and Pre-Merge TODOs
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: