chore: sync tests from upstream.#651
Merged
stephenamar-db merged 1 commit intodatabricks:masterfrom Mar 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Summary
Root Cause: The JS/Native/WASM platforms utilize the
scala-yamllibrary; specifically, itsparseYamlfunction does not support two features found in YAML multi-document streams:--- <content>— Content immediately following the document marker (e.g.,--- >for a folded scalar, or--- 3for a scalar value).---marker until the next---).Fix Strategy (3 Changes):
src-native/Platform.scala+src-js/Platform.scala: Replaced the manualsplitYamlDocumentsimplementation withparseManyYamlsto correctly handle inline content scenarios such as--- >and--- 3. Added aaddExplicitNullsForEmptyDocspre-processing step to insert explicitnulltext for empty documents, thereby bypassingscala-yaml's limitation regarding the handling of empty documents.src-js/Platform.scala(nodeToJsonfunction): Added a match case forNone(specificallycase null | None => ujson.Null) to ensure consistency with the Native platform.scala-yamlreturnsNonewhen decodingnullscalars, a scenario that was previously unhandled on the JS platform.test/src/ParseYamlTests.scala: Added regression tests to cover scenarios involving--- 3,--- >, empty documents, bare document markers, and similar cases.