Updates to PR #31#42
Closed
smurching wants to merge 38 commits into
Closed
Conversation
Signed-off-by: Sid Murching <sid.murching@databricks.com>
Signed-off-by: Sid Murching <sid.murching@databricks.com>
Signed-off-by: Sid Murching <sid.murching@databricks.com>
Signed-off-by: Sid Murching <sid.murching@databricks.com>
1) Dogfood seems to have an issue where tool calling is returning a nonexistent function name. See trace in https://e2-dogfood.staging.cloud.databricks.com/editor/notebooks/2948323364468680?o=6051921418418893#command/397386389372146 2) For RAG only agent, getting 'AttributeError: 'LLMConfig' object has no attribute 'tools'' because RAG agent config object doesn't have a tools field. See https://e2-dogfood.staging.cloud.databricks.com/editor/notebooks/2948323364468746?o=6051921418418893#command/397386389372955 Signed-off-by: Sid Murching <sid.murching@databricks.com>
Signed-off-by: Sid Murching <sid.murching@databricks.com>
* utils modules are not importable when agent notebooks are run directly * Need to fix logging util * Autologged traces and manual traces in langchain don't interleave properly Signed-off-by: Sid Murching <sid.murching@databricks.com>
* Restore ModelConfig across examples * Switch back to OAI SDK * Document tools class Signed-off-by: Sid Murching <sid.murching@databricks.com>
Signed-off-by: Sid Murching <sid.murching@databricks.com>
Signed-off-by: Sid Murching <sid.murching@databricks.com>
Signed-off-by: Sid Murching <sid.murching@databricks.com>
Signed-off-by: Sid Murching <sid.murching@databricks.com>
Signed-off-by: Sid Murching <sid.murching@databricks.com>
epec254
reviewed
Nov 3, 2024
|
|
||
| # COMMAND ---------- | ||
|
|
||
| # from datapipeline_utils.file_loading import load_files_to_df |
Contributor
There was a problem hiding this comment.
from utils.data_pipeline.file_loading ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
#31
What changes are proposed in this pull request?
Applies updates to #31. In particular:
utils. This has the advantage of enabling unit testing in the future and improving overall maintainability, but does make some notebooks less self-containedBaseToolbase class for tool definitions that allows for more-automatic serialization and deserialization (though still not perfect) of the tool definition. This updated serialization approach supports buildling up a set of shared / common tools in Python modules and reusing them across agents (no more need to manually specify the fully-qualified classname of tools in agent configs), and shifts the complexity of specifying agent tools from specifying classname strings to extending a base class.TODOs:
How is this PR tested?
Manually tested all notebooks