skills(experimental): propagate ace-review correctness/security fixes from a-d-k#534#97
Merged
Merged
Conversation
Mirrors the four fixes shipping in ai-dev-kit#534 to the same files under experimental/. Each of these files was carried over verbatim from a-d-k and still had the bugs the original PR fixes: - fm-parallel-calls.py: guard div-by-zero on speedup calc when total_time is below clock resolution; convert trailing module-level docstring (was unreachable as docs) into a real comment block. - llm_config.py: stop echoing the raw token-endpoint response and HTTP body in error messages — they can contain credentials. Surface the shape (payload keys / status code) instead. - 5-serving-and-vector-search.py: replace the syntactically-broken example `query_vector=[0.1, 0.2, 0.3, ...]` (literal Ellipsis tuple) with a real list[float] stand-in plus a comment about matching the index's embedding dimension. - fm-minimal-chat.py: fix `streamlit run 2-minimal-chat-app.py` / `command: ["streamlit", "run", "2-minimal-chat-app.py"]` in the docstring — the actual filename is `fm-minimal-chat.py`. (Skill-name reference left as `databricks-model-serving` to match DAS naming.) The compute.py fix from #534 doesn't apply here — that file was removed in PR #90. Co-authored-by: Isaac
jamesbroadhead
requested review from
dustinvannoy-db,
lennartkats-db and
simonfaltum
as code owners
simonfaltum
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirrors the four fixes shipping in databricks-solutions/ai-dev-kit#534 to the same files under
experimental/. Each of these files was carried over verbatim from a-d-k and still had the bugs that PR fixes.Files
experimental/databricks-apps-python/examples/fm-parallel-calls.pytotal_timeis below clock resolution; convert trailing module-level docstring (unreachable as docs) into a real comment blockexperimental/databricks-apps-python/examples/llm_config.pyexperimental/databricks-python-sdk/examples/5-serving-and-vector-search.pyquery_vector=[0.1, 0.2, 0.3, ...](literal Ellipsis tuple) with a reallist[float]stand-in + a comment about matching the index's embedding dimensionexperimental/databricks-apps-python/examples/fm-minimal-chat.pystreamlit run 2-minimal-chat-app.py/command: ["streamlit", "run", "2-minimal-chat-app.py"]in the docstring — the actual filename isfm-minimal-chat.py. Skill-name reference left asdatabricks-model-servingto match DAS namingThe
compute.pyfix from #534 doesn't apply here — that file was removed in #90.Test plan
python3 scripts/skills.py validatecleanThis pull request and its description were written by Claude.