Skip to content

refactor(query): replace usize with Symbol as the global column ID for the SQL layer#19517

Merged
forsaken628 merged 2 commits intodatabendlabs:mainfrom
forsaken628:column-id
Mar 9, 2026
Merged

refactor(query): replace usize with Symbol as the global column ID for the SQL layer#19517
forsaken628 merged 2 commits intodatabendlabs:mainfrom
forsaken628:column-id

Conversation

@forsaken628
Copy link
Copy Markdown
Collaborator

@forsaken628 forsaken628 commented Mar 7, 2026

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Expectations are merely simple type substitutions.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions Bot added the pr-feature this PR introduces a new feature to the codebase label Mar 7, 2026
@forsaken628 forsaken628 requested a review from sundy-li March 7, 2026 17:11
@forsaken628 forsaken628 changed the title feat(query): replace usize with Symbol as the global column ID for the SQL layer refactor(query): replace usize with Symbol as the global column ID for the SQL layer Mar 8, 2026
@github-actions github-actions Bot added the pr-refactor this PR changes the code base without new features or bugfix label Mar 8, 2026
@forsaken628 forsaken628 removed the pr-feature this PR introduces a new feature to the codebase label Mar 9, 2026
@forsaken628 forsaken628 merged commit 22b5972 into databendlabs:main Mar 9, 2026
172 of 174 checks passed
@forsaken628 forsaken628 deleted the column-id branch March 9, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-refactor this PR changes the code base without new features or bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants