Conversation
PR Summary 🚀
Keep going, team! This progress is exactly what we need to take our project to the next level! 🌟💪 |
charts/base/templates/keda.yaml
Outdated
| maxReplicaCount: {{ .Values.autoscaling.maxReplicas }} | ||
| triggers: | ||
| - type: {{ .Values.autoscaling.trigger.type }} | ||
| {{- range .Values.autoscaling.trigger }} |
There was a problem hiding this comment.
lets support both trigger and triggers, both with single/list ability, with backward compatibility, check config, ingress, multi-containers options we have with similar ways implemented
| - type: memory | ||
| metadata: | ||
| type: Utilization | ||
| value: "75" |
There was a problem hiding this comment.
- this code chunck seems placed in wrong place and should go into examples/base/with-keda-multiple-triggers.yaml file
- I see triggers.[].metadata.type has been deprecated in favor to triggers.[].metricType, so lets have helm code/templates and examples be aligned to not use deprecated form: https://keda.sh/docs/2.17/scalers/cpu/#trigger-specification
| @@ -1,4 +1,6 @@ | |||
| {{- if and .Values.autoscaling.enabled .Values.autoscaling.trigger }} | |||
There was a problem hiding this comment.
this condition seems prevents the case when we pass variable triggers and not trigger
| @@ -1,4 +1,6 @@ | |||
| {{- if and .Values.autoscaling.enabled .Values.autoscaling.trigger }} | |||
| {{- $triggersRaw := (coalesce .Values.autoscaling.triggers .Values.autoscaling.trigger) }} | |||
There was a problem hiding this comment.
lets name this variable just $triggers
| @@ -11,12 +13,17 @@ spec: | |||
| minReplicaCount: {{ .Values.autoscaling.minReplicas }} | |||
| maxReplicaCount: {{ .Values.autoscaling.maxReplicas }} | |||
| triggers: | |||
There was a problem hiding this comment.
seems here we simply can use the following instead of all the range loop block, lets check if this works and have less code form used:
triggers: {{ toYaml $triggers | nindent 2 }}
No description provided.