Add S3 Terraform scaffolding and D2 runbook#51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
H-008as design + IaC scaffolding for secure S3 storage, with provisioning explicitly deferred untilD2(upload flow gate).What Changed
Terraform resources/policies include:
havenhold-{env}-{account-id}BlockPublicAccesson all 4 flagsBucketOwnerEnforcedACL modelaws:kmswith AWS-managedaws/s3) +bucket_key_enabledaws:SecureTransport=falsedeny)havenhold-apiwith prefix-scoped object access to:uploads/*exports/*temp/*Env scaffolding
AWS_*placeholders and runbook pointer.Runbook
Verification
D0 verification completed:
terraform planresult: 7 to add, 0 to change, 0 to destroytrueBucketOwnerEnforcedsse_algorithm = "aws:kms"+bucket_key_enabled = trueforce_destroy = falseScope Boundary
This PR is D0 scaffolding only:
terraform applyis intentionally deferred toD2