Skip to content

Conversation

@kmilos
Copy link
Collaborator

@kmilos kmilos commented Oct 11, 2024

Refs. #516

This is just a basic POC, largely based around the darktable imageio_jxl reader.


if (status == JXL_DEC_NEED_IMAGE_OUT_BUFFER) {
size_t size =
basicinfo.xsize * basicinfo.ysize * basicinfo.num_color_channels;

Check warning

Code scanning / CodeChecker

The left operand of '*' is a garbage value

The left operand of '*' is a garbage value
JxlDecoderDestroy(decoder);

const Array2DRef<uint16_t> tmp(complete_buffer.data(),
basicinfo.num_color_channels * basicinfo.xsize,

Check warning

Code scanning / CodeChecker

The left operand of '*' is a garbage value

The left operand of '*' is a garbage value
@github-actions
Copy link

The proposed diff is not clang-formatted.
To make this check pass, download the following patch
(via browser, you must be logged-in in order for this URL to work),
(NOTE: save it into the repo checkout dir for the snippet to work)
https://github.com/darktable-org/rawspeed/actions/runs/15758629170/artifacts/3363237698
... and run:

cd <path/to/repo/checkout> # NOTE: use your own path here
unzip clang-format.patch.zip
git stash # Temporairly stash away any preexisting diff
git apply clang-format.patch # Apply the diff
git add -u # Stage changed files
git commit -m "Applying clang-format" # Commit the patch
git push
git stash pop # Unstast preexisting diff
rm clang-format.patch.zip clang-format.patch

@schwittlick
Copy link

Anything we can do to move this forward?

@0fbcb238c0
Copy link

LibRaw 0.22 released with support for compiling with Adobe's DNG SDK. Are there plans to use it for decoding 1.7 DNGs with JXL?

@kmilos
Copy link
Collaborator Author

kmilos commented Jan 16, 2026

Anything we can do to move this forward?

There has been zero feedback on this PR so far.

Are there plans

No such plans here.

In any case, I'm personally not intending to keep working on this given the current circumstances. Anyone should feel free to pick up this POC and run with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants