ARW: Support new LJPEG compression on ILCE-7M4 and ILCE-7R5, approach 2 #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support large-resolution ARW from ILCE-7RM5 * Generalize sonyArrange in LJPEG arrangement to support 1x2 Co-authored-by: Artemis Tosini <me@artem.ist>
Recap: due to crop size roundup to multiples of tile size (512) Sony lossless files exhibit black areas if not further cropped down to actual pixel area, which is covered by the sensor. Exif.SubImage1.0x7038 seems to reliably provide the true crop size, whereas Exif.SubImage1.DefaultCropSize only crops to OOC jpeg size losing some pixel area
* upstream/pr/482: Do not apply crop from cameras.xml and set crop origin to 0,0 Boyscout: make sony exif tag naming consistent Use Exif.SubImage1.0x7038 field for Sony lossless compression crop ARW: Support new LJPEG compression on ILCE-7M4 and ILCE-7R5
…ld for square MCU's
`#pragma omp for` is non-sensical on itself.
Looks like UBSan sanitizes even the OpenMP-produced synthetic computations, and thus `rwDecoder.cpp:337:5: runtime error: unsigned integer overflow: 0 - 1 cannot be represented in type 'unsigned int'`.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #484 +/- ##
============================================
+ Coverage 38.54% 59.07% +20.53%
============================================
Files 643 232 -411
Lines 36905 13886 -23019
Branches 5073 1944 -3129
============================================
- Hits 14224 8203 -6021
+ Misses 22106 5550 -16556
+ Partials 575 133 -442
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #482 & #386,
and an alternative take to that of #483,
one that does not require fusing everything into the LJpegDecompressor.