Raster Mask: PNG support and image folder #20170
Open
+249
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Aah :-) Had a quick first look right now with nothing appearing bad to me now. will review and check the next days. Also, welcome to the party! |
jenshannoschwalm
added
feature: enhancement
TurboGit
requested changes
Jan 24, 2026
Member
TurboGit
left a comment
TurboGit
left a comment
There was a problem hiding this comment.
Not tested yet. Two points:
See 66d9708 for the updated _check_extension().
Also be prepared for conflicts when #20198 is merged.
Do we really want the extra complexity for enforcing the mask directory. Current behavior which is remembering the last used directory seems just fine to me.
All in all I think you should separate the work in two PR. One for supporting PNG and one for the root directory to be discussed.
TIA.
|
|
||
| char *extension = g_strrstr(filename, "."); | ||
| char *ext_lower = extension ? g_ascii_strdown(extension, -1) : NULL; | ||
| const gboolean is_png = ext_lower && !g_strcmp0(ext_lower, ".png"); |
Member
There was a problem hiding this comment.
Simplify with : g_ascii_strcasecmp()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The png support fixes issue #19667 and part of issue #19829.
The image folder possibly fix #19689
The relative path fixes issue #20088