Cleanup obsolete code and add ruff/mypy#9
Merged
edgarpavlovsky merged 3 commits intomainfrom Jan 22, 2026
Merged
Conversation
- Remove duplicate .claude-plugin/commands/fireteam.md (plugin.json points to commands/fireteam.md) - Remove docs/ralph-comparison-audit.md (internal comparison doc) - Remove src/hooks.py and tests/test_hooks.py (unused SDK-based hooks that were never called - system uses CLI subprocess, not SDK hooks) - Update README.md: - Change "Claude Agent SDK" to "Claude Code CLI" - Remove ANTHROPIC_API_KEY requirement (uses Claude Code session) - Remove non-existent run_tests parameter from API docs - Remove "Quality Hooks" section (deleted SDK hooks) - Update project structure to reflect actual file layout Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add ruff and mypy to dev dependencies - Configure ruff with sensible defaults (E, W, F, I, B, C4, UP rules) - Configure mypy in strict mode for src/ - Fix all ruff lint errors (import sorting, unused imports/variables) - Fix all mypy type errors (17 errors across 7 files): - Add missing return type annotations - Add type parameters to generic types (dict, Match) - Fix type narrowing issues in closures - Use relative imports in claude_hooks - Update CI workflow with new "Lint & Type Check" job All checks now pass: - ruff check src/ tests/ - mypy src/ - pytest tests/ (88 passed, 1 skipped) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Cleanup (commit 1)
.claude-plugin/commands/fireteam.mddocs/ralph-comparison-audit.mdsrc/hooks.py,tests/test_hooks.py)Quality Gates (commit 2)
Test plan
uv run ruff check src/ tests/passesuv run mypy src/passesuv run pytest tests/passes (88 passed, 1 skipped)🤖 Generated with Claude Code